مراجعة قشرة الزيارة مقابل النموذج المعتمد

Slice A — layout engine, catalog, registry, persistence, edit mode, client settings

FE root = /home/moonui3/public_html/moon-erp/src/app/features/clinic/visit-shell/ (abbrev vs/). BE root = /home/moonui3/moon-erp-be/Modules/.

Verdict on the client settings screen: ❌ MISSING. The prototype's «⚙ إعدادات الشكل / Program Setting» panel (proto 1245-1265, screenshot 16_settings.png) has no FE screen. Here is what exists in its place:

• (a) the in-shell «✎ تخصيص الشاشة» editor, which only edits the card layout;
• (b) the generic /clinic/settings page, which shows only clinic.visit_shell, clinic.layout.allow_doctor_override (group clinic_modes) and dental.feature.* (group «الأسنان»).

Everything else exists in the API only, with no UI:

• field rules {visible, required, input};
• gyn.feature.*;
• the per-type features.shell switch.

1. Verdict table

2. Real bugs found (implemented but wrong)

No hard defects in the resolve/persist path. Minor misbehaviours:

• Editor card count is per tab. visit-shell.component.html:70 passes layout()?.cards?.length, but layout() is the open tab only (visit-shell.component.ts:260-263). On tabbed layouts (nutrition/dental) the bar says e.g. «1 كارت» instead of the draft total. The prototype counts state.draft.cards (1141).
• ↑↓ can be a silent no-op on tabbed layouts. layout-edit.ts:74-84 swaps with the neighbour in the same column across the whole draft, including cards on another tab. The card moves "under" an invisible card. Latent only while dental/nutrition saves stay locked.
• dent_workspace is not required (dental.cards.ts:23-32), unlike proto dent_chart.required:true (463). Once Decision 7 is lifted, «✕ إخفاء» will be enabled on the jaw chart, and resolveLayout will not re-insert it if a saved layout omits it.
• The Decision 7 lock is now stale. The comment at visit-shell.component.ts:268 says the lock waits for the BE to keep layout.tabs/props. The BE does keep them (VisitLayoutController.php:57-58, 107-114). If the lock is still wanted, its stated reason should be updated.

3. Top 5 gaps by owner impact

• No client settings screen (⚙ Program Setting): field visible/required/input, elements and gyn features have no UI. This is the headline difference from what the owner approved (16_settings.png).
• gyn.feature.* and the nutrition/dental features.shell switch can only be set by API/DB. A real centre cannot lock Urogyn/Sexual or turn on the specialty shells itself.
• Element toggles are not implemented: hdr.insurance, dx.secondary, hdr.lastVisit, hdr.doctor, complaint.hpi, lab.prev and rx.interact have no consumer. Only complaint.quick has one, via field rules.
• The vitals card does not compose specialty or context packs. It is always the fixed 8 vitals, and there is no compact/readonly mode prop.
• Several shared cards are rail-only or missing from the catalog: results, current meds, photos, intake status. Layout editing is also limited to general and gyn_ob, and only from inside a live encounter.

B-shell-chrome — prototype vs implementation (read-only audit)

Paths: FE = moon-erp/src/app/features/clinic/, VS = FE/visit-shell/, BE = moon-erp-be/Modules/Clinic/app/. Proto = visit-shell-prototype.html.

1. Verdict table

2. Real bugs found (implemented but wrong)

• B1 — Insurance name never shows, always «نقدي». VS/visit-header.component.ts:106 reads summary().insurance.company_name. BE PatientReadService.php:91 returns $patient->insurance_info as-is, which LIS writes as an array [{contract_id, contract_name}] (FE features/lis/patients/lis-patients.component.ts:533-536; services/clinic-patient.service.ts:220-221). An array has no .company_name. The FE type ClinicPatientInsurance {company_name, coverage_percent} (clinic-patient.service.ts:69-73) describes a payload the BE never sends. The same defect is in the classic shared/clinic-patient-header/clinic-patient-header.component.html:97, so fix it once in the shared layer (either the BE maps insurance → {company_name: insurance_info[0].contract_name}, or the FE reads [0].contract_name). Dev has 0 insured patients, so a live check won't catch it. The finish gate is not affected (it uses encounter.is_insured).
• B2 — «آخر النتائج» never flags abnormal values. visit-start-rail.component.ts:58-59 colours by r.flag, which is declared optional in ClinicPatientLabResult (clinic-patient.service.ts:75-79). BE lastLabsList() (PatientReadService.php:256-260) returns only {name, value, unit}, so every result renders green (HbA1c 7.4 looks normal). Clinically misleading. Fix: the BE sends the result flag/abnormal status (and the unit and date).
• B3 — FE and BE sign gates use slightly different rules. FE finishBlocked (shell.ts:488) accepts any is_primary. BE DiagnosisService::blockSignForInsured (L124-131) also requires code IS NOT NULL. The shell's diagnosis panel always saves ICD codes (diagnosis-panel.component.ts:158), so only legacy or uncoded primary rows reach the BE 422 (English message toast). Low severity.
• B4 — Possible dead end for insured patients. For general, finishBlocked (shell.ts:483-489) blocks even when the client layout removed the diagnosis card (the type-specific exemption at L487 applies only to non-general types). The doctor sees ⛔ + «أضيفه من تخصيص الشاشة», but without can_manage / allow_doctor_override there is no customise button (shell.ts:291-294), so the doctor must go to the classic screen. The reverse case (nutrition/dental, insured, no dx card) lets the doctor press sign, and the BE returns 422 anyway (EncounterService.php:248). The FE «soft» promise there is false; it is the S2 Decision 5 territory, so it needs an owner call.
• B5 — The complaint note can be lost on fast sign or navigation. visit-complaint-card.component.ts:114 debounces 800 ms. ngOnDestroy (L117-119) unsubscribes without flushing, and saveNote returns early once locked (L183). Text typed less than 800 ms before «توقيع» or leaving the page is never saved. The exam card has the same debounce pattern (L133); worth checking.
• B6 — Cosmetic numbering mismatch. The live-summary rail numbers every non-bare card (summary-rail:28, i + 1 over summaryLines), while card heads number stations only (stationIndex). In the general default the collapsed timeline shifts the rail numbers by one for followup.

3. Top 5 gaps by owner impact

• B1: the insurance name in the header (shell and classic) always reads «نقدي». It contradicts the insured sign gate and is visible on every visit.
• B2: latest results are all green, so abnormal values are not flagged in the start rail (plus no date or unit).
• Inpatient: no «حساب الإقامة» bill in the end rail (it shows the encounter's service order) and no admitting doctor in the header.
• Collapsed and signed read-back: history, documents and previous show blank summary lines, and the rx/vitals/lab lines refresh only on «تم». The signed visit (15_signed.png) therefore reads thinner than the proto.
• Phone: orders and bill are unreachable (end rail hidden, mobsum has no bill total); tablet touch targets are 32px, not 44px. The missing Rh-negative alert chip comes next.

Slice C — picker / lookups / favourites / field rules / computed

Paths: BE = /home/moonui3/moon-erp-be/Modules, FE = /home/moonui3/public_html/moon-erp/src/app. Picker = FE shared/components/clinical-picker/.

1. Verdict table

2. Real bugs found (implemented but would misbehave)

• The general complaint and exam pickers are empty on a fresh or dev install: there is no seed. On dev company 1 there are 0 rows of complaint with specialty NULL/general and 0 rows of exam.finding (SELECT on clinical_lookups). Only complaint/gyn_ob (20) comes from gyn:install-pack. The complaint card asks for specialty='general' (visit-shell.component.html:250 → LookupCatalogService.php:41-44), so it gets []. The exam card then drops to the "no regions" fallback (exam-card.ts:79-86). No seeder or migration in Modules/* inserts either key (grep). So on general visits the two flagship pick-don't-type cards show nothing to pick, and roles without clinic.history.manage (dev: doctor, gyn_doctor) cannot even add values.
• The exam Select⟷Text rule is keyed by a company-specific DB id (exam_finding_<parent row id>, exam-card.ts:153,157). A rule cannot be shipped in a default or copied between installs, and it breaks if a region is re-created. The prototype used stable keys (exam_general, exam_chest …). clinical_lookups.code exists (D2a) and should be the key.
• BE inline-add does not validate parent_id (StoreLookupRequest.php:95: nullable|integer). The id is not checked to belong to the same company or lookup_key, so a value can be filed under another key's or tenant's category row. Its specialty is also not checked against known types, and the FE never sends it (clinical-lookup.service.ts:26-32). So every inline-added GYN complaint becomes core (visible to all specialties).
• Cache drift across specialties. add() and toggleFavorite() patch only the key|specialty cache entry they were called with (clinical-lookup.service.ts:79-81,92-94). A value starred or added under gyn_ob does not show as starred or present in the same key's general cache until reload. Minor.
• A failed list (403) re-fires HTTP on every changed bump. On error, catchError deletes the cache and never sets rows (service :63-66). Each box's effect (picker-box.ts:174-183) then calls list() again on every add or ★ anywhere. This is a perf leak for users without clinic.history.view.
• Short GYN lists rendered open cannot be starred or searched by non-managers. The «＋» that opens the dialog only shows when canAdd is true (gyn-lookup-field.component.ts:37,84), so a doctor without clinic.history.manage never reaches the ★ for lists of ≤6/≤7.

3. Top 5 gaps by owner impact

• There is no seed catalog for general complaint and exam.finding (with regions), so the general visit's pick-don't-type cards are empty out of the box (Bug 1).
• Inline add-new is gated on clinic.history.manage, which the stock doctor / gyn_doctor roles lack, and there is no catalog admin screen to fix or reorder or deactivate values. "Managed catalog" is half-done.
• There is no client settings UI for field rules (Select⟷Text, visible, required) or for elements. The renderer honours only 2 element keys and 2 input rules, and the doctor-level override of fields is missing.
• Diagnosis (no ★, no group browse) and History (legacy chips, no catalog) are not on the picker engine. Lab and rad keep their legacy pickers spread on the card instead of chips + a «اختيار» button.
• GYN multi-selects (incl. categories) are stored as JSON code arrays in history answers, not link rows. That is better than CSV, but reports like "how many patients have X" still need JSON queries, which goes against spec guard (b).

Decision: favourites and add-new are REAL, not cosmetic. Favourites are persisted per doctor in clinical_lookup_favorites (lookups) and clinic_favorites (lab / rad / drug / service); the server sorts them first and they are scoped by company and user. Add-new is persisted, idempotent, and permission-checked on BE (clinic.history.manage) and FE. Their usefulness on general visits is limited by the empty seed catalog and by the permission most doctor roles lack.

Slice D — specialties (nutrition / dental / gyn) + inpatient context + clinic/center

Paths: FE = /home/moonui3/public_html/moon-erp/src/app/features/, VS = FE/clinic/visit-shell/, BE = /home/moonui3/moon-erp-be/Modules/. Proto = visit-shell-prototype.html.

1. Verdict table

2. Real bugs found (implemented but would misbehave)

• GYN visit in the inpatient context ends up with two discharge cards and a leftover follow-up. The context replaces only the shared followup with inp_discharge (inpatient.context.ts:65). The GYN default also has gyn_discharge (gyn-shell-cards.ts:125) and gyn_followup (:131), and those stay. An admitted GYN patient sees «الخروج» twice (GYN discharge module + admission discharge order) plus the GYN follow-up schedule. It's not data-corrupting, but it is confusing.
• Specialty and inpatient vitals definitions are seeded but never rendered. ClinicObservationDefinitionSeeder.php:88-112 seeds nut_waist/nut_hip/…, gyn_fundal_height/gyn_fetal_hr and rr/consciousness/pain/intake/output/news2, but VITALS_WHITELIST (clinic-vitals.service.ts:30-39) caps the vitals card at the 8 core fields. A client who enables or edits these definitions expecting them in «العلامات الحيوية» will see nothing. That's dead config, not a crash.
• Inpatient round has no I/O fields. NursingController accepts intake_ml/output_ml (:132-133), but the round form (vital-round.component.html:7-10) has no inputs for them, so fluid balance can't be recorded from the shell.
• GYN feature locks can't be set from the UI. GynFeatures reads clinic.visit_layouts['gyn_ob'].features (GynFeatures.php:9-11, 52-60). The FE save sends {clinical_type, layout} only (visit-shell.component.ts:782), and no setting definitions exist. The approved «عيادة د. منى» lock (screenshot 25) can only be made with a raw API call.

(Lesser: an inpatient nutrition visit prescribes through the board's own app-clinic-prescription dialog (board html:650) with no kind=inpatient, because the nutrition layout has no shared rx card for cardProps to reach.)

3. Top 5 gaps by owner impact

• Nutrition is still one monolithic board (📝 S2b). Every board element can be reached today, but per-card hide/reorder for the client (the proto's main point for nutrition) isn't possible.
• There's no UI for gyn.feature.* (fertility/obstetrics/urogyn/sexual/oncology/operations). Enforcement works, but an admin can't turn a group off.
• Specialty and context vitals packs (waist/hip/WHR, FHR/fundal/urine/LMP-GA, RR/AVPU/I-O) aren't in the vitals card. They're spread over body comp, the antenatal card and the round card, and the round card has no I/O.
• Clinic vs center isn't one context. It's 4 separate settings (ordering/lab/rad/pharmacy), and inpatient doesn't force intent ordering.
• The inpatient header has no admitting doctor or expected length of stay, falls back to a bare chip for users without hospital.beds.view, and a GYN admission shows duplicate discharge/follow-up cards.